]> dgit.raspbian.org Git - gnome-shell.git/commitdiff
appDisplay: Update folder dialog field before ungrabbing
authorGeorges Basile Stavracas Neto <georges.stavracas@gmail.com>
Wed, 24 Jun 2020 18:32:27 +0000 (15:32 -0300)
committerGeorges Basile Stavracas Neto <georges.stavracas@gmail.com>
Wed, 24 Jun 2020 21:06:21 +0000 (18:06 -0300)
Noticed while working on customizable folders. Calling GrabHelper.ungrab()
ends up calling FolderDialog.popdown(), but at this point the '_isOpen'
field isn't updated yet, so we end up calling popdown() twice.

Update the '_isOpen' field before ungrabbing.

https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1332

js/ui/appDisplay.js

index ff813f3954783e4cdd24fb4d4c32e6625571bb13..807c43a539416558a41e55cf20e8fe0fdc8f0fe9 100644 (file)
@@ -1782,8 +1782,8 @@ var AppFolderDialog = GObject.registerClass({
         this._zoomAndFadeOut();
         this._showFolderLabel();
 
-        this._grabHelper.ungrab({ actor: this });
         this._isOpen = false;
+        this._grabHelper.ungrab({ actor: this });
         this.emit('open-state-changed', false);
     }
 });